Dump with no aliases and remove root underscore #42
Conversation
Dump without aliases, i.e., expand out references. Option to dump without root level sub-object underscore.
matthewrmshin
force-pushed
the
feature/dump-no-aliases-no-underscore
branch
from
4775f0c to
5ef1d72
Compare
steoxley
left a comment
steoxley
left a comment
There was a problem hiding this comment.
Looks good. One typo. Note, I haven't tested, and trust your self review declaration is accurate.
Co-authored-by: Stephen Oxley <stephen.oxley@metoffice.gov.uk>
mikecooke77
left a comment
mikecooke77
left a comment
There was a problem hiding this comment.
This all looks good and I've tested it locally on an offline file. It would be useful to test as part of malak. Could a version of this be installed somewhere on the exa and I can then point malak at that instead of the one in the stack?
| yaml.dump(data, infile) | ||
| outfilename = tmp_path / 'b.yaml' | ||
| main([str(infilename), str(outfilename)]) | ||
| main([str(infilename), '-o', str(outfilename)]) |
There was a problem hiding this comment.
Is this a change in behaviour or are you just being explicit?
There was a problem hiding this comment.
This is introduced in a previous change and is nicer CLI usage (as multiple arguments can now be used to concat files). So being explicit here.
|
I'll look to how to install something on the HPC. (Not straightforward as yamlprocessor is installed as a Python package in the stack. I can build a local stack+main in my environment to test with malak.) |
|
@mikecooke77 Can use this build on exab (excd one still building):
Or start up malak with |
mikecooke77
left a comment
mikecooke77
left a comment
There was a problem hiding this comment.
I can confirm this is behaving as expected when comparing the output to the overnight testing. I have run two of the kgos to check no issue and all looks good see here:
malak kgo_glu_jopa_jada
sith kgo_glu
This is a really helpful improvement as it will allow us to separate out the kgo and operational observation settings for jada and jopa. We can also rationalise the jada yamls to just gl rather than glm and glu specific ones.
|
Note the failure in the above is because I had var highres switched on which differs from the kgo run normally. This can be ignored. |
Description
Dump without aliases, i.e., expand out references. Option to dump without root level sub-object underscore.
Issue(s) addressed
Resolves #41.
Checklist